Skip to content

Add Guest OS mapping for windows server 2025 on VMware #12358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Pearl1594 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Guest OS mapping for windows server 2025 on VMware #12358

Pearl1594 wants to merge 1 commit into from
+14 −0

Conversation

@Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Dec 31, 2025 •
edited
Loading

Description

This PR adds guest os and mappings for Windows Server 2025
Addresses: #12324
Deployed a new virtual machine on vmware 8.0.3 and set the guest os to Windows server 2025 and found the mapping

image

on ESXi host - the guest os it guest mapped to is windows2022srvNext_64Guest
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

VM OS Type
image

ISO registered with OS type Windows Server 2025:
image

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Dec 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (46cb805) to head (f7f2655).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #12358   +/-   ##
=========================================
  Coverage     17.60%   17.60%           
- Complexity    15668    15669    +1     
=========================================
  Files          5915     5915           
  Lines        529967   529967           
  Branches      64734    64734           
=========================================
  Hits          93304    93304           
+ Misses       426195   426194    -1     
- Partials      10468    10469    +1
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Pearl1594 Pearl1594 marked this pull request as ready for review January 2, 2026 19:03
@Pearl1594
Copy link
Contributor Author

Pearl1594 commented Jan 2, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 2, 2026

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 2, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16233

DaanHoogland
DaanHoogland approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, but should this not go on earlier versions than 23?

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti sureshanaparti linked an issue Jan 6, 2026 that may be closed by this pull request
Windows Server 2025 ISO VM maps as “Other” OS type in vCenter on CloudStack 4.21 (VMware 8.0.3) #12324
Open
shwstppr
shwstppr approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shwstppr
shwstppr reviewed Jan 7, 2026
View reviewed changes
engine/schema/src/main/resources/META-INF/db/schema-42210to42300.sql
UPDATE `cloud`.`configuration` SET value='firstfit' WHERE name IN ('vm.allocation.algorithm', 'volume.allocation.algorithm') AND value='userconcentratedpod_firstfit';

-- Add Windows Server 2025 guest OS and mappings
CALL ADD_GUEST_OS_AND_HYPERVISOR_MAPPING (6, 'Windows Server 2025 (64-bit)', 'VMware', '7.0', 'windows2022srvNext_64Guest');
Copy link
Contributor

@shwstppr shwstppr Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should stop using constant category IDs as they are dynamic now

Copy link
Contributor

@DaanHoogland DaanHoogland Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today is a good day to die… ;)

weizhouapache
weizhouapache approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

this is a minor guest os support, can we move to schema-42200to42210.sql ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

status:has-conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows Server 2025 ISO VM maps as “Other” OS type in vCenter on CloudStack 4.21 (VMware 8.0.3)

5 participants

@Pearl1594 @blueorangutan @shwstppr @DaanHoogland @weizhouapache